Skip to content

core affinity on mac noop#733

Merged
leafaar merged 6 commits intorpcpool:masterfrom
grooviegermanikus:fix-core-affinity-on-mac-noop
Apr 27, 2026
Merged

core affinity on mac noop#733
leafaar merged 6 commits intorpcpool:masterfrom
grooviegermanikus:fix-core-affinity-on-mac-noop

Conversation

@grooviegermanikus
Copy link
Copy Markdown
Contributor

Project does not compile on MacOS because the crate affinity uses for core pinning does not support MacOS.

Solution

Implement no-op for MacOS and delegate to crate affinity for linux+windows.

picking up this #643

@leafaar
Copy link
Copy Markdown
Contributor

leafaar commented Apr 22, 2026

@grooviegermanikus could you check the cargo deny check advisories please?

@grooviegermanikus
Copy link
Copy Markdown
Contributor Author

my bad. I've updated that crate. that check did not run locally tho - so hope that work now

@grooviegermanikus
Copy link
Copy Markdown
Contributor Author

@leafaar pushed a fix. you might need to click sth to rerun the CI

@leafaar
Copy link
Copy Markdown
Contributor

leafaar commented Apr 24, 2026

@grooviegermanikus now there's cargo fmt, try doing cargo +nightly fmt and also check the clippy with: cargo clippy --workspace --all-targets

@leafaar leafaar merged commit fea7782 into rpcpool:master Apr 27, 2026
2 checks passed
@leafaar
Copy link
Copy Markdown
Contributor

leafaar commented Apr 27, 2026

thanks @grooviegermanikus

leafaar added a commit that referenced this pull request Apr 29, 2026
- bump agave monorepo deps to 4.0.0-rc.0 (geyser-plugin-interface,
  account-decoder, storage-proto, transaction-context, transaction-status)
- bump matching Solana SDK crates (account 3.4.0, hash 4.2.0, message 3.1.0,
  pubkey 4.1.0, signature 3.3.0, transaction 3.1.0, keypair 3.1.0,
  clock 3.0.1, spl-token-2022-interface 2.1.0)
- bump rust toolchain to 1.94.1 (required by agave 4.0.0-rc.0)
- proto: add commission_bps field to Reward (SIMD-0291)
- geyser: wire commission_bps through convert_to / convert_from
- geyser: update TransactionReturnData import path to
  solana_transaction_context::transaction::TransactionReturnData
- fix new clippy 1.94 lints (iter_kv_map, manual_is_multiple_of)
- yellowstone-grpc-geyser 12.3.0 -> 13.0.0
- yellowstone-grpc-proto 12.2.0 -> 12.3.0
- changelog: add entries for #735 (grpc method in bandwidth metrics)
  and #733 (mac noop core affinity) which were missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants